Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check for isListening when negotiationComplete #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorjesinpo
Copy link
Collaborator

Broker can initiate and negotiate connection before startListening.
In this case, cannot close the channel before newly created cluster startDispatched (the latter relies on read callback).

Signed-off-by: Vitaly Dzhitenov <vdzhitenov@bloomberg.net>
@dorjesinpo dorjesinpo added the bug Something isn't working label Jan 25, 2024
@dorjesinpo dorjesinpo requested a review from a team as a code owner January 25, 2024 15:31
Copy link
Collaborator

@hallfox hallfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, can we update with the latest?

@dorjesinpo
Copy link
Collaborator Author

This looks good to me, can we update with the latest?

There is test failure - test_queue_close.py::test_close_while_reopening[multi_node] - that seems to be relevant. On the first glance, timing changes and cluster fails to synchronize. We need to spend more time looking but this is not the highest priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants