Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat[MQB]: Support listening on multiple ports #204

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Feat[MQB]: Support listening on multiple ports #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/groups/mqb/mqbcfg/doc/mqbcfg.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ broker, as well as the generated corresponding messages component.

/Hierarchical Synopsis
/---------------------
The 'mqbcfg' package currently has 2 components having 2 level of physical
The 'mqbcfg' package currently has 3 components having 2 levels of physical
dependency. The list below shows the hierarchical ordering of the components.
..
1. mqbcfg_messages
2. mqbcfg_brokerconfig
2. mqbcfg_tcpinterfaceconfigvalidator
..

/Component Synopsis
Expand All @@ -23,3 +24,5 @@ broker, as well as the generated corresponding messages component.
: BMQBroker generated configuration messages.
: 'mqbcfg_brokerconfig'
: Provide global access to broker configuration.
: 'mqbcfg_tcpinterfaceconfigvalidator'
: Provide validation logic for `appConfig/networkInterfaces/tcpInterface/listeners` in the broker configuration.
25 changes: 25 additions & 0 deletions src/groups/mqb/mqbcfg/mqbcfg.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,10 @@
<complexType name='TcpInterfaceConfig'>
<annotation>
<documentation>
name.................:
The name of the TCP session manager.
port.................:
(Deprecated) The port to receive connections.
lowWatermark.........:
highWatermark........:
Watermarks used for channels with a client or proxy.
Expand All @@ -243,6 +247,9 @@
heartbeatIntervalMs..:
How often (in milliseconds) to check if the channel received data,
and emit heartbeat. 0 to globally disable.
listeners:
A list of listener interfaces to receive TCP connections from. When non-empty
this option overrides the listener specified by port.
</documentation>
</annotation>
<sequence>
Expand All @@ -255,6 +262,24 @@
<element name='nodeLowWatermark' type='long' default='1024'/>
<element name='nodeHighWatermark' type='long' default='2048'/>
<element name='heartbeatIntervalMs' type='int' default='3000'/>
<element name='listeners' type='tns:TcpInterfaceListener' minOccurs='0' maxOccurs='unbounded'/>
</sequence>
</complexType>

<complexType name='TcpInterfaceListener'>
<annotation>
<documentation>
This type describes the information needed for the broker to open a TCP listener.

name.................:
A name to associate this listener to.
port.................:
The port this listener will accept connections on.
</documentation>
</annotation>
<sequence>
<element name='name' type='string'/>
<element name='port' type='int'/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to retire the above port when all broker versions read new config.
We need to mark it as deprecated maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can mark it deprecated in the schema documentation. The behavior of what the broker should do is probably better documented in other documentation sources too.

</sequence>
</complexType>

Expand Down
Loading
Loading