Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed k_DEFAULT_SUBSCRIPTION_ID to k_DEFAULT_SUBQUEUE_ID #237

Closed
wants to merge 1 commit into from
Closed

Changed k_DEFAULT_SUBSCRIPTION_ID to k_DEFAULT_SUBQUEUE_ID #237

wants to merge 1 commit into from

Conversation

ADTmux
Copy link
Contributor

@ADTmux ADTmux commented Apr 3, 2024

Change k_DEFAULT_SUBSCRIPTION_ID to k_DEFAULT_SUBQUEUE_ID #236

Describe your changes
Just replaced k_DEFAULT_SUBSCRIPTION_ID to k_DEFAULT_SUBQUEUE_ID

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Signed-off-by: AmitDave22 <amitdavecse@gmail.com>
@ADTmux ADTmux requested a review from a team as a code owner April 3, 2024 21:04
@pniedzielski pniedzielski self-requested a review April 3, 2024 21:16
@pniedzielski pniedzielski self-assigned this Apr 3, 2024
@pniedzielski
Copy link
Collaborator

pniedzielski commented Apr 3, 2024

@ADTmux Take a look at the compile error in our CI. k_DEFAULT_SUBQUEUE_ID isn't a member of bmqp::Protocol::. The k_DEFAULT_SUBQUEUE_ID we want is mentioned a few lines above.

Please build and test your PRs before submitting them, because even trivial changes like this can fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants