Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat[MQB]: track queue depth per appId #320

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat[MQB]: track queue depth per appId #320

wants to merge 6 commits into from

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jun 12, 2024 •
edited
Loading

  • Set queue stats to VirtualStorageCatalog on Primary and update per-appId queue metrics on these calls, if necessary
  • Do sort json stats on admin command
  • Add all the remaining queue metrics to json output
  • Regenerate queue stats IT expected data

@678098 678098 requested a review from a team as a code owner June 12, 2024 13:04
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch from 01396d3 to 9222a9a Compare July 5, 2024 17:38
@678098 678098 changed the title [WIP]Feat: track queue depth per appId Feat[MQB]: track queue depth per appId Jul 5, 2024
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch from 9222a9a to 90a7c9e Compare July 5, 2024 17:46
678098
678098 commented Jul 5, 2024
View reviewed changes
src/groups/mqb/mqbstat/mqbstat_jsonprinter.cpp
, d_opsPretty(bdljsn::WriteOptions()
.setSpacesPerLevel(4)
.setStyle(bdljsn::WriteStyle::e_PRETTY)
.setSortMembers(true))
Copy link
Collaborator Author

@678098 678098 Jul 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort is necessary to have less diff when we update sample json data in ITs
On the other hand, I can do this in ITs

@678098 678098 requested a review from kaikulimu July 5, 2024 17:50
@kaikulimu kaikulimu assigned dorjesinpo and unassigned kaikulimu Jul 5, 2024
@kaikulimu kaikulimu requested a review from dorjesinpo July 5, 2024 19:41
@678098 678098 force-pushed the t2360_appId_queue_depth_2 branch 4 times, most recently from 4f55f63 to 8ae6b9c Compare August 2, 2024 23:16
@678098
Feat: track queue depth per appId
50a73a0 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Cleanup
84335ab 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Less code
b00d5c7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update queue metrics IT
e26590a 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Remove QueueStatsDomain callbacks
a0af51c 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
MQBSTAT: extend json queue metrics
102331e 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Aug 27, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 187 of commit 102331e has completed with FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmq-oss-ci BMQ OSS CI bmq-oss-ci left review comments

@kaikulimu kaikulimu Awaiting requested review from kaikulimu

@dorjesinpo dorjesinpo Awaiting requested review from dorjesinpo

At least 1 approving review is required to merge this pull request.

Assignees

@dorjesinpo dorjesinpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@678098 @kaikulimu @dorjesinpo