Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor, CI: automatic license check, fix licenses #330

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Refactor, CI: automatic license check, fix licenses #330

merged 2 commits into from
Jun 21, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jun 20, 2024 •
edited
Loading

CI job output example:

Run python3 /home/runner/work/blazingmq/blazingmq/.github/workflows/ext/check_license.py --path=/home/runner/work/blazingmq/blazingmq | tee missing_licenses.txt
/home/runner/work/blazingmq/blazingmq/src/groups/mqb/mqbc/mqbc_clusterdata.cpp:
// BAD LICENSE EXAMPLE

@678098 678098 requested a review from a team as a code owner June 20, 2024 14:14
@678098 678098 force-pushed the 240620_auto_license_checks branch from 7e6f28a to afc2a50 Compare June 20, 2024 14:16
@678098
Refactor, CI: automatic license check, add missing licenses
53b5e44 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098 678098 force-pushed the 240620_auto_license_checks branch 2 times, most recently from 827af6d to 53b5e44 Compare June 20, 2024 14:20
@678098 678098 changed the title Refactor, CI: automatic license check, add missing licenses Refactor, CI: automatic license check, fix licenses Jun 20, 2024
@678098 678098 requested a review from chrisbeard June 21, 2024 13:11
chrisbeard
chrisbeard approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@chrisbeard chrisbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should probably do similar for the client library repos?

@678098
Copy link
Collaborator Author

678098 commented Jun 21, 2024

Looks good to me. We should probably do similar for the client library repos?

Yep, for client libs it's a good thing to do. But we should also extend this for other languages like Java.

@678098 678098 merged commit 95cc97f into bloomberg:main Jun 21, 2024
23 checks passed
@678098 678098 deleted the 240620_auto_license_checks branch June 21, 2024 18:55
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor, CI: automatic license check, add missing licenses (bloomber…
ce35168 
…g#330)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor, CI: automatic license check, add missing licenses (bloomber…
8d2b9c7 
…g#330)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor, CI: automatic license check, add missing licenses (bloomber…
435f177 
…g#330)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbeard chrisbeard chrisbeard approved these changes

Assignees

@chrisbeard chrisbeard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @chrisbeard