MQB: wait for unconfirmed before buffering confirms #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
changed the title
dorjesinpo
changed the title
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/remote-queue-confirms-buffering
branch
from
4af02cf to
fbbb695
Compare
dorjesinpo
changed the title
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx: do not start buffering CONFIRMs in (remote) queue upon deconfigure response (upon StopRequest processing) because that is too early when waiting for unconfirmed.
Early buffering increases chances of duplicate PUSH messages - those received by RemoteQueue between deconfigure response and finishing waiting for unconfirmed.
Still need to start buffering broadcast PUTs early, otherwise broadcast PUT can get lost.
Still, duplicates are possible in few ITs because of the scenario when a CONFIRM had passed Proxy but did not reach the replication. New Primary then redelivers and the Proxy cannot detect the duplicate because it had removed the GUID upon the first CONFIRM