Fix trivial compiler warnings #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unused variables - Missing newlines Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
chrisbeard
force-pushed
the
fix-compiler-warnings
branch
from
5136466 to
6e0a33a
Compare
hallfox
approved these changes
Jun 27, 2024
lukedigiovanna
pushed a commit
to lukedigiovanna/blazingmq
that referenced
this pull request
Jul 2, 2024
* Fix trivial compiler warnings - Unused variables - Missing newlines Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Fix FileManagerImpl class name comment header Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Fix trivial compiler warnings - Unused variables - Missing newlines Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Fix FileManagerImpl class name comment header Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Fix trivial compiler warnings - Unused variables - Missing newlines Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Fix FileManagerImpl class name comment header Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
* Fix trivial compiler warnings - Unused variables - Missing newlines Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Fix FileManagerImpl class name comment header Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also found one class that was probably renamed, but comment block wasn't updated to match.