Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqbconf.xsd: Move flag to publish appId metircs from mqbcfg.xsd #353

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

kaikulimu
Copy link
Collaborator

No description provided.

@kaikulimu kaikulimu requested review from chrisbeard and jll63 July 9, 2024 21:39
@kaikulimu kaikulimu requested a review from a team as a code owner July 9, 2024 21:39
@kaikulimu
Copy link
Collaborator Author

The Python formatting check failed. I am using black (24.4.2) locally, while GitHub Actions is using black (21.12b0-1). We should update the black version in GitHub Actions.

@kaikulimu kaikulimu force-pushed the appIdTagDomains branch 2 times, most recently from fa430dd to c662660 Compare July 10, 2024 19:40
@kaikulimu kaikulimu assigned kaikulimu and jll63 and unassigned kaikulimu Jul 10, 2024
@678098
Copy link
Collaborator

678098 commented Jul 11, 2024

Install the latest formatter
#355

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
@kaikulimu
Copy link
Collaborator Author

@jll63 Ready for your review again

@kaikulimu kaikulimu merged commit 410f71c into bloomberg:main Jul 30, 2024
29 checks passed
@kaikulimu kaikulimu deleted the appIdTagDomains branch August 28, 2024 21:14
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
…mberg#353)

* mqbconf.xsd: Add flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbcfg.xsd: Remove flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbstat::QueueStatsDomain: Use domain flag for publish appId metrics

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* docs plugins.md: Remove appIdTagDomains

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* configurator/__init__.py: Clean up removed config option

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbconf, mqbcfg: Generated Python code

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* test_admin_client.py: Use new publish appId metrics flag

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

---------

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
…mberg#353)

* mqbconf.xsd: Add flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbcfg.xsd: Remove flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbstat::QueueStatsDomain: Use domain flag for publish appId metrics

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* docs plugins.md: Remove appIdTagDomains

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* configurator/__init__.py: Clean up removed config option

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbconf, mqbcfg: Generated Python code

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* test_admin_client.py: Use new publish appId metrics flag

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

---------

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
…mberg#353)

* mqbconf.xsd: Add flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbcfg.xsd: Remove flag to publish appId metircs

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbstat::QueueStatsDomain: Use domain flag for publish appId metrics

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* docs plugins.md: Remove appIdTagDomains

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* configurator/__init__.py: Clean up removed config option

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* mqbconf, mqbcfg: Generated Python code

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

* test_admin_client.py: Use new publish appId metrics flag

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>

---------

Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants