Fix sanitizer issues [BMQ,MWC] #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
alexander-e1off
commented
Jul 24, 2024
alexander-e1off
commented
Jul 24, 2024
alexander-e1off
commented
Jul 24, 2024
| reqOptions.setAttemptInterval( | ||
| bsls::TimeInterval(0, 10 * bdlt::TimeUnitRatio::k_NS_PER_MS)); | ||
|
|
||
| reqOptions.setAttemptInterval(bsls::TimeInterval(0, 1)); |
There was a problem hiding this comment.
I'm not sure I understand why the second call of setAttemptInterval with such strange arguments (1 ns) is required.
678098
reviewed
Jul 25, 2024
etc/ubsansup.txt
Outdated
| # option is to update the code, which can be done by someone feeling | ||
| # adventurous. | ||
| alignment:crc32c1024SseInt | ||
| # UndefinedBehaviorSanitizer suppressions file for BMQ. |
There was a problem hiding this comment.
Suggested change
| # UndefinedBehaviorSanitizer suppressions file for BMQ. | |
| # UndefinedBehaviorSanitizer suppressions file for BlazingMQ. |
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
678098
requested changes
Aug 14, 2024
etc/tsansup.txt
Outdated
| # point. | ||
| race:TestSession::waitForChannelClose | ||
| race:TestSession::arriveAtStepWithCfgs | ||
| # Suppress sporadically appearing data race in bmqimp::Brokersession test driver. |
There was a problem hiding this comment.
Suggested change
| # Suppress sporadically appearing data race in bmqimp::Brokersession test driver. | |
| # Suppress sporadically appearing data race in bmqimp::BrokerSession test driver. |
etc/tsansup.txt
Outdated
| # at nearly same time in other thread bmqimp::BrokerSession::onConfigureQueueResponse() calls | ||
| # queue->options().suspendsOnBadHostHealth() method which is detected as data race. | ||
| # bmqt::QueueOptions and bmqimp::Queue classes are not thread safe by design, | ||
| # and bmqimp::BrokerSession::onConfigureQueueResponse() cllback access them in |
There was a problem hiding this comment.
Suggested change
| # and bmqimp::BrokerSession::onConfigureQueueResponse() cllback access them in | |
| # and bmqimp::BrokerSession::onConfigureQueueResponse() callback access them in |
| @@ -248,6 +248,10 @@ class TestChannel : public Channel { | |||
| /// Pops a close-call from those written to the channel (FIFO ordering). | |||
| CloseCall popCloseCall(); | |||
|
|
|||
| /// Lock mutex and return `true` if d_closeCalls collection is empty, | |||
| /// `false` otherwise. | |||
| bool closeCallsEmpty(); | |||
There was a problem hiding this comment.
Might qualify as const and make mutex mutable
There was a problem hiding this comment.
Fixed as proposed.
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
syuzvinsky
pushed a commit
to syuzvinsky/blazingmq
that referenced
this pull request
Aug 30, 2024
alexander-e1off
added a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
alexander-e1off
added a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
alexander-e1off
added a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise cancelled/suppressed unit tests running under sanitizers. Fix some issues.