UT[MWC]: C++20: Fix -Wvolatile warnings #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
force-pushed
the
fix-volatile-warning
branch
from
07cdbd8 to
2a729af
Compare
C++20 has completely deprecated `volatile`, and GCC enables multiple warnings to catch invalid volatile uses. Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
hallfox
force-pushed
the
fix-volatile-warning
branch
from
2a729af to
9a10c65
Compare
pniedzielski
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
👏🏻 👏🏻 👏🏻
(nit: only deprecated in the places it's broken, like thread-safety, not in places it has no replacement, like hardware register access: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1152r4.html and previous versions)
678098
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 has completely deprecated
volatile, and GCC enables multiple warnings to catch invalid volatile uses.