mqbc::ClusterUtil: Revert to not populate appId infos in non-CSL mode #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
dorjesinpo
requested changes
Aug 26, 2024
|
Asserts were removed in 78bce9b. I reverted the appId population logic, but kept the assert removals |
dorjesinpo
previously approved these changes
Aug 26, 2024
Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
dorjesinpo
approved these changes
Aug 26, 2024
syuzvinsky
added a commit
to syuzvinsky/blazingmq
that referenced
this pull request
Aug 30, 2024
…CSL mode (bloomberg#408)" This reverts commit 71a9660.
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…bloomberg#408) * mqbc::ClusterUtil: Revert to not populate appId infos in non-CSL mode Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> * test_restart.py: temporarily disable non-FSM to FSM tests Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> --------- Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…bloomberg#408) * mqbc::ClusterUtil: Revert to not populate appId infos in non-CSL mode Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> * test_restart.py: temporarily disable non-FSM to FSM tests Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> --------- Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…bloomberg#408) * mqbc::ClusterUtil: Revert to not populate appId infos in non-CSL mode Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> * test_restart.py: temporarily disable non-FSM to FSM tests Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net> --------- Signed-off-by: Yuan Jing Vincent Yan <yyan82@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318 introduces compatibility issues if we run a cluster with brokers of mixing versions 0.92.4 and 0.92.7, because bmqbrkr_0.92.4 asserts that appId infos are not populated in
QueueAssignmentAdvisory. Therefore, we decide to split into two releases: where 0.92.8 will remove the assert, and 0.92.9 will populate the appId infos. Then, we can run a mix of bmqbrkr_0.92.8 and bmqbrkr_0.92.9 without error.