Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to Python schema and tweak generators #410

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jll63
Copy link
Collaborator

@jll63 jll63 commented Aug 28, 2024

  • Remove xsdata[cli] from Python pip requirements file, because it requires ruff and then in turn Rust.
  • Changes to schemagen:
    • If xsdata is not available, require user to install it manually.
    • Add copyright notice to generated files.
    • black-format the generated files.
  • tweakgen: add copyright notice to generated file, and black-format it.

@678098
Copy link
Collaborator

678098 commented Aug 29, 2024

@jll63 we can merge this PR to fix python UTs #411
There are also issues with quotes in the schemagen script

Signed-off-by: Jean-Louis Leroy <jleroy9@bloomberg.net>
…, black

Signed-off-by: Jean-Louis Leroy <jleroy9@bloomberg.net>
@678098
Copy link
Collaborator

678098 commented Aug 29, 2024

@jll63 Need to also manually install black in CI

@jll63
Copy link
Collaborator Author

jll63 commented Aug 30, 2024

@jll63 Need to also manually install black in CI

I added black to requirements.txt. But I am not certain this is right. On one hand black is just like xsdata[cli] - it is needed by the two generators only. On the other hand, it does not pull heavy dependencies like xsdata[cli] does.

If we decide to not put black in the requirements, then I will have to make the two generators whine if it is not found, like schemagen also does with xsdata. Let's think about it over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants