Fix[MQB]: Normalize "PartitionID [n]" to "Partition [n]" in logs #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
chrisbeard
force-pushed
the
mqb-partition-logs
branch
from
d105a5d to
8dcb018
Compare
Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
678098
previously approved these changes
Sep 27, 2024
Co-authored-by: Evgeny Malygin <678098@protonmail.com> Signed-off-by: Chris Beard <chrisbeard@users.noreply.github.com>
678098
previously approved these changes
Sep 27, 2024
Signed-off-by: Christopher Beard <cbeard9@bloomberg.net>
678098
approved these changes
Sep 27, 2024
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…omberg#424) * Fix[MQB]: Normalize "PartitionID [n]" to "Partition [n]" in logs Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Update src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Co-authored-by: Evgeny Malygin <678098@protonmail.com> Signed-off-by: Chris Beard <chrisbeard@users.noreply.github.com> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> Co-authored-by: Evgeny Malygin <678098@protonmail.com>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…omberg#424) * Fix[MQB]: Normalize "PartitionID [n]" to "Partition [n]" in logs Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Update src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Co-authored-by: Evgeny Malygin <678098@protonmail.com> Signed-off-by: Chris Beard <chrisbeard@users.noreply.github.com> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> Co-authored-by: Evgeny Malygin <678098@protonmail.com>
alexander-e1off
pushed a commit
to alexander-e1off/blazingmq
that referenced
this pull request
Oct 24, 2024
…omberg#424) * Fix[MQB]: Normalize "PartitionID [n]" to "Partition [n]" in logs Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> * Update src/groups/mqb/mqbblp/mqbblp_clusterqueuehelper.cpp Co-authored-by: Evgeny Malygin <678098@protonmail.com> Signed-off-by: Chris Beard <chrisbeard@users.noreply.github.com> * clang-format Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> --------- Signed-off-by: Christopher Beard <cbeard9@bloomberg.net> Co-authored-by: Evgeny Malygin <678098@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While searching through logs for partition events, we noticed that logs printed the partition using two differently formatted strings. This PR normalizes those logs to one format to make searching through logs easier.