Refactor[mqbblp::Cluster]: use concrete event types #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
force-pushed
the
241008_mqbblp_cluster_concrete_types
branch
3 times, most recently
from
698c5f6 to
5785ac4
Compare
678098
commented
Oct 8, 2024
| @@ -443,25 +443,25 @@ class Cluster : public mqbi::Cluster, | |||
| void processClusterSyncRequest(const bmqp_ctrlmsg::ControlMessage& request, | |||
| mqbnet::ClusterNode* requester); | |||
|
|
|||
| void onPutEvent(const mqbi::DispatcherEvent& event); | |||
| void onPutEvent(const mqbi::DispatcherPutEvent& event); | |||
|
|
|||
| void onRelayPutEvent(const mqbi::DispatcherEvent& event); | |||
There was a problem hiding this comment.
This method is the only exception for this refactor
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
241008_mqbblp_cluster_concrete_types
branch
from
5785ac4 to
d6836a2
Compare
|
@kaikulimu rebased after MWC migration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates interfaces for
mqbblp::Cluster::on[...]Event, by putting concrete event types in the args.It allows to get rid of excessive assert check within these methods like
BSLS_ASSERT_SAFE(mqbi::DispatcherEventType::e_CONFIRM == event.type());It also allows to get rid of accessing for a concrete event type the second time like
const mqbi::DispatcherPushEvent* realEvent = event.asPushEvent();This PR also restores missing checks for being in dispatcher thread.
The only exception to (1) is
void onRelayPutEvent(const mqbi::DispatcherEvent& event);which usessource()accessorThis is a preparation PR for #396