Refactor: Merge mwc into bmq #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallfox
force-pushed
the
merge-mwc-bmq
branch
2 times, most recently
from
7af4108 to
761193a
Compare
|
@hallfox some failing clang-format checks...probably (though not obviously, to me) related to your rename. Probably best to pay this debt down now rather than merge with failing CI. |
hallfox
force-pushed
the
merge-mwc-bmq
branch
from
761193a to
0bbb1d3
Compare
|
Tested this patch doxygen, thankfully nothing new was built. This should make it easier to build docs for former-MWC, though. |
|
Still see three references to mwc: |
pniedzielski
requested changes
Oct 18, 2024
hallfox
force-pushed
the
merge-mwc-bmq
branch
from
0bbb1d3 to
d250020
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
hallfox
force-pushed
the
merge-mwc-bmq
branch
from
d250020 to
05a4ca4
Compare
MWC or "MiddleWare Core" was a package group developed to support a myriad of applications at Bloomberg. It's been useful to share common middleware components between similar technologies, but doesn't make much sense to support as its own open source library. Moving forward we are merging it into the BMQ package group to better maintain it for the BlazingMQ project. Signed-off-by: Taylor Foxhall <tfoxhall@bloomberg.net>
hallfox
force-pushed
the
merge-mwc-bmq
branch
from
05a4ca4 to
ab17a4e
Compare
chrisbeard
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
lgtm, maybe @pniedzielski can give a second sanity check here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MWC or "MiddleWare Core" was a package group developed to support a myriad of applications at Bloomberg. It's been useful to share common middleware components between similar technologies, but doesn't make much sense to support as its own open source library. Moving forward we are merging it into the BMQ package group to better maintain it for the BlazingMQ project.