Fix[mqbblp::RemoteQueue]: 0 deduplication timeout causes expired PUTs #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
changed the title
678098
changed the title
… REPLICA Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098
force-pushed
the
241031_fix_zero_deduplication_timeout_replica
branch
from
2d2c902 to
37d1450
Compare
678098
changed the title
678098
changed the title
dorjesinpo
reviewed
Oct 31, 2024
| @@ -483,6 +483,19 @@ RemoteQueue::RemoteQueue(QueueState* state, | |||
| os << '@' << d_state_p->uri().asString(); | |||
| d_state_p->setDescription(os.str()); | |||
|
|
|||
| if (deduplicationTimeMs <= 0) { | |||
| d_pendingPutsTimeoutNs = 5 * | |||
There was a problem hiding this comment.
let's have a k_ constant instead of 5
Or, the default dedup timeout
| << "non-positive timeout from config [" | ||
| << deduplicationTimeMs << " ms], use a default PUT " | ||
| << "deduplication timeout for scheduler instead [" | ||
| << bmqu::PrintUtil::prettyTimeInterval( |
There was a problem hiding this comment.
let's print the minutes, easier to read?
There was a problem hiding this comment.
Pretty time interval prints 5.00 m, you want to print the full 5 minutes instead, right?
There was a problem hiding this comment.
If this is 5.00 m, then it is ok. Just did not want long string of zeroes
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
|
@dorjesinpo I moved 5 to unit's constants. Also, changed the log line so it mentions |
dorjesinpo
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deduplicationTimeMsparameter serves at least 2 roles:With the second point, we got a bug. When we provide 0 timeout, we schedule PUT expiration almost immediately on REPLICA/PROXY, causing some of the PUTs to expire before reaching PRIMARY.
This PR handles 0 (and just for safety negative values, if someone wants to pass -1) for
deduplicationTimeMs, and now we assume that "zero deduplication timeout means we don't want to expire messages for as long as we can". We use a default 5 minute timer in this case.The sample WARN log from PROXY:
31OCT2024_17:33:11.257 (140251446843136) WARN mqbblp_remotequeue.cpp:488 Remote queue [@bmq://bmq.capmon.priority.sc/dummy]: cannot schedule PUT expiration timer with a non-positive timeout from config [0 ms], use a default PUT expiration timeout for scheduler instead [5.00 m]