Fix[MQB]: remove maxDeliveryAttempts range check #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emelialei88
force-pushed
the
fix/maxDeliveryAttempts-limit
branch
from
687408a to
31dc7b8
Compare
emelialei88
changed the title
emelialei88
changed the title
emelialei88
changed the title
emelialei88
force-pushed
the
fix/maxDeliveryAttempts-limit
branch
from
fdaf867 to
186ba23
Compare
emelialei88
changed the title
pniedzielski
requested changes
Nov 4, 2024
emelialei88
force-pushed
the
fix/maxDeliveryAttempts-limit
branch
from
654d77b to
ee0c1ea
Compare
- The change made in _crash_consumer_restart_leader comment is to match the comment with the code. - Before removing the if block in `mqbblp_domain.cpp`, `maxDeliveryAttempts` is reset to 5 if it's between 1-4, which is wrong since we want users to be able to set it to any value. The test `test_poison_rda_reset_priority_active` originally set `maxDeliveryAttempts` to 2 but attempted 3 deliveries. Before removing the if block this would work since `maxDeliveryAttempts` is reset to 5, but after the fix, the initial value for `maxDeliveryAttempts` should also change to 3. Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
fix/maxDeliveryAttempts-limit
branch
from
ee0c1ea to
f7ea92b
Compare
pniedzielski
approved these changes
Nov 4, 2024
|
Test failure seems unrelated; will look into in a different changeset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user uncovered an unfortunate (and undocumented) limitation in the behavior of poison pill configurations, we do not allow users to set this to 1-4 (using the default broker configurations).
We should allow users to configure these as valid values for the number of delivery attempts.