Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix[m_bmqstoragetool_filemanager.h]: rollback redundant template arg #544

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Fix[m_bmqstoragetool_filemanager.h]: rollback redundant template arg #544

merged 2 commits into from
Jan 7, 2025

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Dec 11, 2024 •
edited
Loading

The CI fails to build this:

[2024-12-10T17:40:43.101Z] /blazingmq/src/applications/bmqstoragetool/m_bmqstoragetool_filemanager.h:130:44: error: template-id not allowed for destructor

[2024-12-10T17:40:43.101Z]   130 | inline FileManagerImpl::FileHandler<ITER>::~FileHandler<ITER>()

[2024-12-10T17:40:43.101Z]       |                                            ^

https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2237

@678098 678098 requested a review from a team as a code owner December 11, 2024 09:22
@678098 678098 requested a review from hallfox December 11, 2024 09:23
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Dec 11, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 412 of commit a076911 has completed with FAILURE

@678098 @pniedzielski
Fix[m_bmqstoragetool_filemanager.h]: rollback redundant template arg …
aa3a1b0 
…for destructor

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Dec 16, 2024
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 416 of commit aa3a1b0 has completed with FAILURE

bmq-oss-ci[bot]
bmq-oss-ci bot reviewed Jan 7, 2025
View reviewed changes
Copy link

@bmq-oss-ci bmq-oss-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 422 of commit 3b4b551 has completed with FAILURE

@678098 678098 merged commit 14e95e8 into main Jan 7, 2025
36 of 37 checks passed
@678098 678098 deleted the 678098-patch-4 branch January 7, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmq-oss-ci bmq-oss-ci[bot] bmq-oss-ci[bot] left review comments

@hallfox hallfox hallfox approved these changes

Assignees

@hallfox hallfox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @hallfox