Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log delete trace #4906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve log delete trace #4906

wants to merge 1 commit into from
+66 −64

Conversation

morgando
Copy link
Contributor

@morgando morgando commented Dec 13, 2024 •
edited
Loading

  • include file name in trace messages where appropriate
  • prepend function name to trace messages

@morgando
Improve logdel trace
4fe74ac 
Signed-off-by: Morgan Douglas <mdouglas47@bloomberg.net>
roborivers
roborivers suggested changes Dec 14, 2024
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/591 tests failed ⚠.

The first 10 failing tests are:
writes_remsql_names_negativerowid_generated [setup failure]
basic [setup failure]
phys_rep_perf
snap_ha_retry_newsi_generated
tunables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morgando @roborivers