Skip to content

Add prevoffset to comdb2_transaction_logs #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

@markhannum markhannum commented May 6, 2025

This pr includes the log-header's c_prev variable (previous offset) to comdb2_transaction_logs. Emit a 'newfile' log when the transaction log changes.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/606 tests failed ⚠.

The first 10 failing tests are:
fdb_compat
phys_rep_tiered_nosource_generated

@markhannum markhannum force-pushed the logprev branch 2 times, most recently from 3dae610 to 6b4cc98 Compare May 6, 2025 19:55
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 33/606 tests failed ⚠.

The first 10 failing tests are:
selectv_deadlock
deadlock_load_noreorder_generated
deadlock_load
sc_timepart_logicalsc_generated
sc_timepart
sc_truncate_multiddl_generated
sc_truncate
truncatesc_offline_generated
logarchive
fdb_compat

@markhannum markhannum force-pushed the logprev branch 2 times, most recently from 5ada199 to 7f74d71 Compare May 7, 2025 22:25
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/606 tests failed ⚠.

The first 10 failing tests are:
logfill
sc_truncate
insert_lots_ssl_generated
schemalk_logicalsc_generated
logarchive
fdb_compat
sc_downgrade
incoherent_sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 11/606 tests failed ⚠.

The first 10 failing tests are:
logfill
sc_timepart
sc_timepart_logicalsc_generated
sc_truncate
sc_redo
logarchive
fdb_compat
sc_lotsoftables
sc_downgrade
incoherent_sql

Write a newfile log when the txn-log changes

Signed-off-by: Mark Hannum <mhannum72@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants