Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function aliasByMetric - Redo #87

Closed
wants to merge 6 commits into from
Closed

Function aliasByMetric - Redo #87

wants to merge 6 commits into from

Conversation

vaguiar
Copy link

@vaguiar vaguiar commented Apr 2, 2020 •
edited
Loading

Describe your changes
Implementing feature aliasByMetric
(Previous incorrect implementation in #84)

Testing performed

  • Unit test
  • Integration tests
  • Tested with mtcmptest tool to verify that other attributes of the series like Tags[name] is unchanged.

Comments
Changes as per Dieterbe's comments on grafana#1755 (comment)

@vaguiar vaguiar requested review from shanson7, agao48 and fqiu7 April 2, 2020 14:17
@vaguiar vaguiar changed the title Func alias by metric Function aliasByMetric - Redo Apr 9, 2020
@vaguiar vaguiar requested a review from agao48 April 13, 2020 22:42
@vaguiar vaguiar closed this Apr 16, 2020
@vaguiar
Copy link
Author

vaguiar commented Apr 16, 2020

Upstream changes merged in grafana#1755

@vaguiar vaguiar deleted the func_aliasByMetric branch April 16, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanson7 shanson7 shanson7 approved these changes

@agao48 agao48 agao48 approved these changes

@fqiu7 fqiu7 fqiu7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaguiar @shanson7 @agao48 @fqiu7