Ensure that reading from error queue does not hang if the socket is in a blocking mode or ::recvmsg returns 0 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrm456
requested changes
Jan 19, 2024
mattrm456
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
OK to merge. I assume we also want to check the control message arena does not contain any control messages, even when recvmsg(MSG_ERRQUEUE) returns 0, to handle edge cases in those Linux kernel versions that have suspicious support for the error queue for TCP sockets, like Linux 3.10.
smtrfnv
changed the title
…n a blocking mode or ::recvmsg returns 0
smtrfnv
force-pushed
the
robust_reading_error_queue
branch
from
31a023a to
31915ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that Linux kernel v3.10 behaves differently from newer kernel versions:
::recvmsg(socket, &msg, MSG_ERRQUEUE);can be blocking::recvmsg(socket, &msg, MSG_ERRQUEUE);can also return 0.This PR fixes such behavior and adds some test cases for that.