-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added yargs to list of popular alternatives in /docs #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Make sure you sign off your commits so that the DCO check is happy.
We did mention Yargs in the Common Patterns section under Method Chaining, but I agree that yargs is ubiquitous enough that it could be repeated under Popular Libraries.
That being said, I would want any description of the library to mention that its approach to TypeScript support requires types to be defined in the parser and then consumed by the implementation (rather than the other way around, which is the approach that Stricli takes).
makes total sense, thanks - making a change to include that. also I just realized that it is installed in node_modules, is a dependency of some of the dependencies of the package. |
@dvidsilva Can you sign off your last commit as well please? https://github.com/bloomberg/stricli/pull/16/checks?check_run_id=31527772548 contains instructions. |
@mkubilayk thanks! just did and force pushed. |
I've rebased the changes but it looks like the DCO check is still not passing.
It looks like there's just some mismatch between your local git config and your GitHub profile. |
80b0f3d
to
35b3f14
Compare
right, I rebased and squashed them, one of them had a different email thanks |
Signed-off-by: Daveed <daveed@santocabron.com>
Signed-off-by: Michael Molisani <git@molisani.us>
Sorry for some of the back and forth, but thank you very much for the contribution! |
Appreciated! it was a great exercise, will send more complex PRs if I run into issues locally |
*Issue number of the reported bug or feature request: #15
Describe your changes
Added a short paragraph about yargs to the popular alternatives
Testing performed
it compiles locally
Additional context
congrats on the launch