Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): add process to context #4

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(create-app): add process to context #4

merged 1 commit into from
Sep 30, 2024

Conversation

mkubilayk
Copy link
Collaborator

@stricli/create-app template creates a context with NodeJS.Process on it - so we add the type that.

@mkubilayk
fix(create-app): add process to context
5f1e969 
Signed-off-by: Kubilay Kahveci <mkahveci@bloomberg.net>
@mkubilayk mkubilayk requested a review from molisani September 30, 2024 21:03
molisani
molisani approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@molisani molisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, I had pushed a branch that built off the CI changes but I logged off before that was merged and couldn't rebase from mobile.

@mkubilayk mkubilayk merged commit 0c502f2 into main Sep 30, 2024
2 checks passed
@mkubilayk mkubilayk deleted the fix/create-app-template branch September 30, 2024 21:07
@molisani molisani added the create-app 📂 Relates to the @stricli/create-app package label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molisani molisani molisani approved these changes

Assignees
No one assigned
Labels
create-app 📂 Relates to the @stricli/create-app package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkubilayk @molisani