fix: loosen character restrictions on flags #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtyjones
commented
Dec 11, 2024
murtyjones
force-pushed
the
mj/allow-multipart-flags
branch
from
df52643 to
e6e6973
Compare
molisani
reviewed
Dec 11, 2024
murtyjones
force-pushed
the
mj/allow-multipart-flags
branch
from
e6e6973 to
b5c7e4e
Compare
murtyjones
force-pushed
the
mj/allow-multipart-flags
branch
from
b5c7e4e to
fcf920c
Compare
molisani
approved these changes
Dec 12, 2024
murtyjones
force-pushed
the
mj/allow-multipart-flags
branch
from
fcf920c to
b25c76e
Compare
murtyjones
changed the title
Loosens the regex used for flag pattern matching to allow: - Periods - Underscores - Digits ...which enables flags like `--foo.bar`, `--foo123`, and `--foo_bar`. Signed-off-by: Marty Jones <mjones721@bloomberg.net>
murtyjones
force-pushed
the
mj/allow-multipart-flags
branch
from
b25c76e to
1baa426
Compare
|
It looks like something's wrong with the auto-label workflow, but that isn't a blocker for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosens the regex used for flag pattern matching to allow:
...which enables flags like
--foo.bar,--foo123, and--foo_bar.