Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: GitHub actions #2

Merged
merged 1 commit into from
Sep 18, 2024
Merged

ci: GitHub actions #2

merged 1 commit into from
Sep 18, 2024

Conversation

acutmore
Copy link
Collaborator

@acutmore acutmore commented Sep 18, 2024 •
edited
Loading

Now GitHub actions are running. Makes various tweaks to get CI green.

@tchetwin tchetwin force-pushed the github-actions branch 4 times, most recently from fceb825 to e767baf Compare September 18, 2024 11:44
@acutmore
ci: use Node 20
4f8e561 
- While the package says we support Node 18 the unit tests are using Node 20 features
- Since the e2e loader test was added we now need to 'build' in 'pretest'
- Fix prettier violations

Signed-off-by: Ashley Claymore <aclaymore@bloomberg.net>
@acutmore acutmore marked this pull request as ready for review September 18, 2024 14:41
@acutmore acutmore requested a review from tchetwin September 18, 2024 14:41
tchetwin
tchetwin approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@tchetwin tchetwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

observation: The package.json engines field is only accurate for library consumers of the package. As-a-loader users need to be on Node 20

@tchetwin tchetwin merged commit 8c610b0 into main Sep 18, 2024
2 checks passed
@tchetwin tchetwin deleted the github-actions branch September 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchetwin tchetwin tchetwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acutmore @tchetwin