fix: handle async generic arrow functions #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubilayk
previously approved these changes
Oct 31, 2024
closes #19 Signed-off-by: Ashley Claymore <aclaymore@bloomberg.net>
acutmore
force-pushed
the
async-generic-arrow
branch
from
8de30d6 to
ba6f6e8
Compare
mkubilayk
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #19
Describe your changes
This updates the transform to detect
asyncarrow functions that have type parameters which span over multiple lines. When this is detected the(at the start of the functions parameters is moved to the start of the type parameters. Avoiding a new line character to appear directly after theasynckeyword.Testing performed
A new fixture has been added that covers the issue being addresses.