Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update from template #6

Merged
merged 12 commits into from
Nov 2, 2024
Merged

Feature/update from template #6

merged 12 commits into from
Nov 2, 2024

Conversation

blooop
Copy link
Owner

@blooop blooop commented Nov 2, 2024

Summary by Sourcery

Update dependencies and CI configuration, and adjust scripts to use local git configuration.

Enhancements:

  • Update dependencies in pyproject.toml to newer versions for pytest-cov, hypothesis, and ruff.

CI:

  • Remove check-clean-workspace dependency from the ci task in the configuration.

Chores:

  • Modify scripts to use local git configuration for pull.rebase instead of global configuration.

blooop and others added 12 commits November 1, 2024 13:21
ci: don't check for clean workspace any more
ci: remove check clean workspace as part of ci
…5 updates

Updates the requirements on [black](https://github.com/psf/black), [pytest-cov](https://github.com/pytest-dev/pytest-cov), [hypothesis](https://github.com/HypothesisWorks/hypothesis), [ruff](https://github.com/astral-sh/ruff) and [coverage](https://github.com/nedbat/coveragepy) to permit the latest version.

Updates `black` to 24.10.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@23.1a1...24.10.0)

Updates `pytest-cov` to 6.0.0
- [Changelog](https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-cov@v4.1.0...v6.0.0)

Updates `hypothesis` to 6.116.0
- [Release notes](https://github.com/HypothesisWorks/hypothesis/releases)
- [Commits](HypothesisWorks/hypothesis@hypothesis-python-6.104.2...hypothesis-python-6.116.0)

Updates `ruff` to 0.7.2
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.5.0...0.7.2)

Updates `coverage` to 7.6.4
- [Release notes](https://github.com/nedbat/coveragepy/releases)
- [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst)
- [Commits](nedbat/coveragepy@7.5.4...7.6.4)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:production
  dependency-group: dev-dependencies
- dependency-name: pytest-cov
  dependency-type: direct:production
  dependency-group: dev-dependencies
- dependency-name: hypothesis
  dependency-type: direct:production
  dependency-group: dev-dependencies
- dependency-name: ruff
  dependency-type: direct:production
  dependency-group: dev-dependencies
- dependency-name: coverage
  dependency-type: direct:production
  dependency-group: dev-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
…4a089230

build(deps): bump the dev-dependencies group across 1 directory with 5 updates
Copy link

sourcery-ai bot commented Nov 2, 2024

Reviewer's Guide by Sourcery

This PR updates dependency version constraints and modifies Git configuration settings. The changes primarily focus on adjusting test dependencies' version ranges and simplifying Git configuration commands.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated version constraints for test dependencies
  • Increased pytest-cov upper bound from 5.0.0 to 6.0.0
  • Increased hypothesis upper bound from 6.115.5 to 6.116.0
  • Increased ruff upper bound from 0.7.1 to 0.7.2
pyproject.toml
Modified CI task dependencies
  • Removed 'check-clean-workspace' from CI task dependencies
pyproject.toml
Updated Git configuration commands in update scripts
  • Changed git config from global to local scope for pull.rebase setting
scripts/update_from_python_template.sh
scripts/update_from_template.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (94f8fa5) to head (eb56c08).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           15        15           
=========================================
  Hits            15        15           

Impacted file tree graph

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blooop - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Can you explain the rationale for removing 'check-clean-workspace' from the CI pipeline dependencies? This check typically helps ensure CI runs aren't affected by untracked or modified files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@blooop blooop merged commit 3bd7a59 into main Nov 2, 2024
9 checks passed
@blooop blooop deleted the feature/update_from_template branch November 2, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant