Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insufficient collateral due to new inputs in change adjustment calculation in balanceTx #226

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Fix insufficient collateral due to new inputs in change adjustment calculation in balanceTx #226

merged 2 commits into from
Mar 18, 2023

Conversation

satran004
Copy link
Member

@satran004 satran004 commented Mar 15, 2023 •
edited
Loading

Fix for #222

Call changeAdjustment before collateral calculation to calculate accurate totalCollateral.

The following calls are happening balanceTx.

  1. Fee calculation
  2. ChangeAdjustement call to check if minAda requirement is met and add additional inputs with updated fee
  3. Total collateral calculation and update value in collateral output

@satran004 satran004 merged commit 592685a into master Mar 18, 2023
@satran004 satran004 deleted the fix_222 branch March 18, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edridudi edridudi Awaiting requested review from edridudi

@matiwinnetou matiwinnetou Awaiting requested review from matiwinnetou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@satran004