Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend-api): #238 getTxOutput(tx,index) in UtxoServicr, UtxoSup… #241

Merged
merged 3 commits into from
May 3, 2023

Conversation

satran004
Copy link
Member

Change for #238

  • New apis to get tx output by txHash and outputIndex, get utxos by asset

UtxoService

Result<Utxo> getTxOutput(String txHash, int outputIndex)
Result<List<Utxo>> getUtxos(String address, String unit, int count, int page, OrderEnum order) 

UtxoSupplier

 Optional<Utxo> getTxOutput(String txHash, int outputIndex);

TransactionService

Result<Utxo> getTransactionOutput(String txnHash, int outputIndex)
  • Added implementations for above apis in all backend providers (Blockfrost, Koios, Kupo)
  • Integration tests

Known Issue

@satran004 satran004 requested a review from edridudi April 23, 2023 13:37
return Result.error("Not Found").withValue(null).code(404);
}
} else {
return Result.error(response.errorBody().string()).code(response.code());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16% of developers fix this issue

NULL_DEREFERENCE: object returned by response.errorBody() could be null and is dereferenced at line 89.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

import lombok.NoArgsConstructor;

@Data
@Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18% of developers fix this issue

MissingSummary: A summary fragment is required; consider using the value of the @return block as a summary fragment instead.


Suggested change
@Builder
Returns {@code this}.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Apr 23, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/bloxbean/cardano-client-lib/241.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/bloxbean/cardano-client-lib/241.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@satran004
Copy link
Member Author

Koios issue (empty datahash, scripthash in output) is still there.
But merging it for now as it's blocking few other changes.

@satran004 satran004 closed this May 3, 2023
@satran004 satran004 reopened this May 3, 2023
@satran004 satran004 merged commit 4a74416 into master May 3, 2023
@satran004 satran004 deleted the feat_238 branch May 3, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant