Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quicktx): Fixed timeout after transaction submission #268

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

satran004
Copy link
Member

No description provided.

@satran004 satran004 merged commit aa66ba9 into master Jun 22, 2023
@satran004 satran004 deleted the fix_complete_wait branch June 22, 2023 15:37
* @param logConsumer consumer to get log messages
* @return Result of transaction submission
*/
public Result<String> completeAndWait(@NonNull Duration timeout, @NonNull Duration checkInterval,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5% of developers fix this issue

UnnecessarilyFullyQualified: This fully qualified name is unambiguous to the compiler if imported.


Suggested change
public Result<String> completeAndWait(@NonNull Duration timeout, @NonNull Duration checkInterval,
public Result<String> completeAndWait(NullPointerException Duration timeout, NullPointerException Duration checkInterval,

❗❗ 2 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/QuickTxBuilder.java 382
quicktx/src/main/java/com/bloxbean/cardano/client/quicktx/QuickTxBuilder.java 383

Visit the Lift Web Console to find more details in your report.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jun 22, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/bloxbean/cardano-client-lib/268.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/bloxbean/cardano-client-lib/268.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant