Implement cip 67 #350
Implement cip 67 #350
Conversation
|
|
||
| import java.nio.ByteBuffer; | ||
|
|
||
| public class CIP67 { |
There was a problem hiding this comment.
Thanks @Kammerlo
Should we rename CIP67 to CIP67AssetName or CIP67AssetNameUtil to give some context ?
| @@ -0,0 +1,20 @@ | |||
| package com.bloxbean.cardano.client.util; | |||
|
|
|||
| public class IntUtil { | |||
There was a problem hiding this comment.
There is a Utils class which has a method with similar functionality uint32ToByteArrayBE. But it's currently in crypto/bip32 package.
I am just wondering if we can use that. Otherwise, we can keep this class but rename it to ByteUtil, allowing us to add additional conversion methods, such as long to bytes, etc later.
There was a problem hiding this comment.
So yes the function would work as well. For me this conversions seemed pretty common so I wasn't looking into the bip32 package for this functionality.
I renamed the package. We can discuss if moving the other functions to a more common place.
No description provided.