#446 Support for CompletableFuture in QuickTxBuilder #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for Optional types in blueprint processing Implemented changes to handle Optional types in blueprint definitions. Added tests for processing blueprints with basic option types and ensured proper compilation. Updated schema and processing utilities to accommodate new Optional type handling. * Add Pair type support and serialization logic Added the Pair type to Type and JavaType enums. Updated BlueprintSchema, ConverterCodeGenerator, and ClassDefinitionGenerator to handle Pair serialization and deserialization. Introduced unit tests to verify Pair functionality. * Fix package issue due to aiken stdlib definitions * To fix #452 Add tests for ScheduledTransactionRedeemer model and related tests
Refactor `COSESignBuilder` and `COSESign1Builder` to handle external payloads and add support for payload hashing. Update `CIP30DataSigner` logic to remove redundant hashed payload header. Adjust tests to align with these changes and add new test files for Rust code comparisons.
Refactor COSESign builders for external payload and hashing
Replaced Constant class with a new TxResult class and TxStatus enum for better transaction result representation and status tracking. Updated QuickTxBuilder methods to return TxResult instead of Result<String>, incorporating status metadata. Adjusted related test cases and methods to align with the new structure.
|
Sotatek-HuyLe3a
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
completeAndWaitAsyncmethods provide asynchronous completion and monitoring status of the submitted transaction. These methods return aCompletableFuturethat allows handling results or exceptions asynchronously.Submit the transaction and waits asynchronously with a default check interval of 2 seconds and logs the progress using the default logging mechanism.
Submits the transaction and waits asynchronously, logging progress messages using the provided
logConsumer. Default check interval 2 sec.Submits the transaction and waits asynchronously, using the provided 1logConsumer1 for logging and the specified executor for execution. Default check interval 2 sec.
Submits the transaction and waits asynchronously, checking the transaction status at the specified interval and logging progress messages using the provided logConsumer.
Submits the transaction and waits asynchronously, checking the transaction status at the specified interval. Logs progress messages using the provided logConsumer and executes the process using the specified executor.
Note: For Java 21 and above, virtual thread can be used by providing the custom executor.
Transaction States:
- TxStatus.SUBMITTED: Indicates that the transaction has been submitted.
- TxStatus.CONFIRMED: Indicates that the transaction has been included in a block.
- TxStatus.PENDING: Indicates a pending transaction.