Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed25519 extended signing #73

Merged
merged 1 commit into from
Jan 25, 2022
Merged

ed25519 extended signing #73

merged 1 commit into from
Jan 25, 2022

Conversation

stikkos
Copy link
Collaborator

@stikkos stikkos commented Jan 25, 2022

This PR aims to provide a pure Java SigningProvider implementation, using the ed25519-java library (https://github.com/str4d/ed25519-java).

  • EdDSASigningProvider.signExtended now signs using ed25519-java library in stead of libcardano_jni_wrapper
  • EdDSASigningProvider.sign has been refactored to also sign using ed25519-java in stead of bouncy castle's implementation
  • Configuration.signingProvider has been changed to EdDSASigningProvider
  • EdDSASigningProviderTest was added to test signing and verifying

@satran004
Copy link
Member

@stikkos Thanks a lot. Looks good to me and all tests including IT are passing.

@satran004 satran004 merged commit c460769 into bloxbean:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants