Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data hash calculation for MinAdaCalculator #77

Merged
merged 1 commit into from Feb 17, 2022
Merged

Add data hash calculation for MinAdaCalculator #77

merged 1 commit into from Feb 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2022

@satran004
Copy link
Member

Thanks a lot for finding this gap and for the PR.

Possible to add few tests with the datum hash scenarios mentioned in (** WITH datum hash: **) section . Let me know

https://github.com/input-output-hk/cardano-ledger/blob/master/doc/explanations/min-utxo-alonzo.rst#example-min-ada-value-calculations-and-current-constants

Fyi, please ignore the test failure in CI. I will update that test after merge.

@satran004
Copy link
Member

Merging this PR. Will add some tests after merge. Many thanks.

@satran004 satran004 merged commit 1601750 into bloxbean:master Feb 17, 2022
@ghost
Copy link
Author

ghost commented Feb 17, 2022

Sorry for the delay. I was stick with work. I'll do that later

@satran004
Copy link
Member

No worries. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants