Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Hyperion" bootstrapper style #232

Merged
merged 19 commits into from
May 14, 2023
Merged

Add "Hyperion" bootstrapper style #232

merged 19 commits into from
May 14, 2023

Conversation

1011025m
Copy link
Contributor

@1011025m 1011025m commented May 9, 2023

This PR will close #169, which adds the fake "Hyperion" bootstrapper as an available style.

My first time doing C#, so most things are just copy&paste lol

@pizzaboxer
Copy link
Member

Nice, not bad for a first try. I'll take a look later.

@1011025m
Copy link
Contributor Author

I was planning to make this theme-aware, but WPF doesn't seem to have native properties for changing the fill colour of SVGs... unfortunate.

I'll let you decide whether you want to add another package to support that or not.

@pizzaboxer
Copy link
Member

What package? If it's not too big, then I probably could.

@1011025m
Copy link
Contributor Author

@pizzaboxer
Copy link
Member

Is it only for SVGs? The resources you added are PNGs.

@1011025m
Copy link
Contributor Author

I will switch them out to SVGs if you're fine with adding the package so I could change the fill colour of them.

@1011025m
Copy link
Contributor Author

There could be lighter libraries that could change the fill colour, I'm not sure, haven't looked around much.

@1011025m
Copy link
Contributor Author

Welp, there we go. I opted for embedding the geometry data into the dialog, no extra packages needed!

it's really jank though, but at least light theme works :)
j87Z4C2Xc9

@pizzaboxer
Copy link
Member

pizzaboxer commented May 10, 2023

Woah, that's way lighter than I expected it to be. Nice work!

@EasternBloxxer
Copy link
Contributor

Neat

@1011025m
Copy link
Contributor Author

1011025m commented May 10, 2023

LGTM at this state, you can always change the version to client version instead of bloxstrap version

@pizzaboxer
Copy link
Member

pizzaboxer commented May 11, 2023

One more thing - what about the Byfron logo in the top left? I'm assuming you used the original SVG for the Roblox logo, so I can probably just invert the colours of the Byfron logo PNG and add it as another resource.

For the version string, I can probably just show it when the close button is hidden in the top right.

@pizzaboxer
Copy link
Member

pizzaboxer commented May 11, 2023

Oh yeah, forgot to mention this, but besides that one Twitter video, I'm referencing this Youtube video since the Twitter video is compressed to 1280x690.

https://www.youtube.com/watch?v=jtUPc16wjR4&t=45s

firefox_wliuMJNqca

@EasternBloxxer
Copy link
Contributor

Old one also didn't have the topbar close button etc

@EasternBloxxer
Copy link
Contributor

Old one also didn't have the topbar close button etc

Original*

@1011025m
Copy link
Contributor Author

The official Byfron logo does not have the "A Roblox Company" caption, someone made that up. I can't recognize the font the exploiters used for that though. Byfron doesn't have a logo in SVG either, so you'll probably have to add two images for dark and light themes.

(well, unless one of you is able to get the svg!)

@1011025m
Copy link
Contributor Author

1011025m commented May 11, 2023

I'm also trying to find the font used for the dialog message and version number. If you can find the exact one (or know the person who created the fake launcher) please let me know.

@user1126s
Copy link

i found a website that finds the font in any image, lettme try that.

@user1126s
Copy link

umm i am having an error, when zoomed in to only capture the version number, it gets blurred thus it shows random fonts. can i get a clear pic of the version photo only?

@pizzaboxer
Copy link
Member

you'll probably have to add two images for dark and light themes.

Yeah, I'll probably just do that.

@kaisiece
Copy link

Maybe the font is Zeppelin 32?

image
image

@1011025m
Copy link
Contributor Author

1011025m commented May 11, 2023

While they do look quite similar, the font in the image is a bit more squished.

Just a reminder the custom font needs to be bundled with the executable, unless the font is available on most systems.

Fonts available on Google Fonts or use OFL should be preferred

@playervalley
Copy link

playervalley commented May 11, 2023

It's a lighter Gotham, probably the Book variant.
image

@1011025m
Copy link
Contributor Author

Gotham is a commercial font and does not come with Windows.

@pizzaboxer
Copy link
Member

Tried matching the text as closely as possible, but still couldn't find a matching font.

@playervalley
Copy link

playervalley commented May 12, 2023

While Gotham Book does match, @1011025m you're right, we would need a license for it. I'd figure that Wix Madefor Display should do, since it is a bit squished and is on Google Fonts.
https://fonts.google.com/specimen/Wix+Madefor+Display

image

@pizzaboxer
Copy link
Member

While Gotham Book does match, @1011025m you're right, we would need a license for it. I'd figure that Wix Madefor Display should do, since it is a bit squished and is on Google Fonts. https://fonts.google.com/specimen/Wix+Madefor+Display

image

Oh nice, that one looks really close.

@stan2474
Copy link

rubrik looks to be the original font used

@brenden7158
Copy link

you would know stan

@1011025m
Copy link
Contributor Author

rubrik looks to be the original font used

We are getting very close!

VDtsCvCoNy

It's not the same font however, look at the letter A and the spacing between letters.

(the text was also intentionally squished, but this will do for now)

@pizzaboxer pizzaboxer merged commit a0bebba into bloxstraplabs:version-2.4.0 May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants