Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralise module filename #90

Closed
wants to merge 7 commits into from

Conversation

kronn
Copy link
Contributor

@kronn kronn commented Jul 12, 2013

This builds upon and thereby replaces #89 and #88. Thanks @adamcohen and @inetdavid.

I put the decision which directory and (following from that) filename the compiled module is found at.

I also reduced the number of templates involved so that centos and ubuntu are more likely to be in sync.

@mshirley
Copy link

You made changes to manifests/passenger/apache/ubuntu/post.pp for the "creates" statement using the new compiled_module_fn variable but didn't make the same change for the manifests/passenger/apache/centos/post.pp file line 17.

https://github.com/kronn/puppet-rvm/blob/fac362a647ecdecbf8010ee9a7226667a65dffa3/manifests/passenger/apache/centos/post.pp#L17

@kronn
Copy link
Contributor Author

kronn commented Jul 17, 2013

Thanks for the pointer, @mshirley. That pretty much proves that my machines run Ubuntu, doesn't it?

I noticed that the CentOS-post manifest does not provide restart hooks for apache. I don't know the specifics of CentOS in that regard, so I did not change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants