Use multicast-socket for broadcasting mdns messages #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces [multicast-socket](https://github.com/bltavares/multicast-socket) as the underlying socket implementation for mdns discovery. It is allowing to listen and broadcast messages on multiple interfaces. Tested and working: - Win x Linux (WSL) discovery - Same host Linux (WSL) discovery Not working: - Same Win discovery Partially working: - Win x Linux (WSL) discovery - Origin address returns 0.0.0.0
|
This PR bltavares/multicast-socket#5 will fix Win x Win discovery and weird WSL discovery as well. Nothing like debugging OS-level network stack errors and FFI debugging for 3 weekends. yay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces
multicast-socket as the
underlying socket implementation for mdns discovery.
It is allowing to listen and broadcast messages on multiple interfaces.
Tested and working:
Not working:
Partially working:
Fixes #15