Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.x breaks some images with an error about content in var #95

Closed
RoyalOughtness opened this issue Feb 27, 2024 · 4 comments · Fixed by #103
Closed

v1.1.x breaks some images with an error about content in var #95

RoyalOughtness opened this issue Feb 27, 2024 · 4 comments · Fixed by #103
Assignees
Labels
type: bug Something isn't working.
Milestone

Comments

@RoyalOughtness
Copy link
Contributor

Found file: var/lib/alternatives/ld
error: Found content in var

https://github.com/secureblue/secureblue/actions/runs/8068238477/job/22040524220#step:8:999

Does not occur on 1.0.2.

@gmpinder gmpinder self-assigned this Feb 27, 2024
@gmpinder
Copy link
Member

So it seems like this directory was created outside a module. In our attempt to use tmpfs mounts for var, we didn't consider users/base images put content in there. We'll have to add back the rm for tmp and var to keep this working.

@RoyalOughtness
Copy link
Contributor Author

RoyalOughtness commented Feb 27, 2024

@gmpinder it's not something we (secureblue) are doing since we made no changes to those images recently, so it's likely something happening in ucore. To be clear, it's only the ucore-nvidia images we're seeing this in:

https://github.com/ublue-os/ucore/blob/main/ucore/Containerfile

@gmpinder
Copy link
Member

@gmpinder it's not something we (secureblue) are doing since we made no changes to those images recently, so it's likely something happening in ucore. To be clear, it's only the ucore-nvidia images we're seeing this in:

https://github.com/ublue-os/ucore/blob/main/ucore/Containerfile

Right I'm saying this is on us to fix

@gmpinder gmpinder added the type: bug Something isn't working. label Feb 27, 2024
@RoyalOughtness
Copy link
Contributor Author

@gmpinder I know, I was just adding some additional context 😄

@gmpinder gmpinder added this to the v0.8.2 milestone Feb 27, 2024
gmpinder added a commit that referenced this issue Feb 28, 2024
Since the command `ostree container commit` checks for the presence of
mounted directories, we will be running it at the end of each module
run. We have also updated the final commit to remove from /tmp/ and
/var/ again in case a user creates extra files through custom
instructions.

Closes #101 #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants