Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(podman-api): Clean up working container for SIGINT and SIGTERM #14

Merged
merged 19 commits into from
Feb 14, 2024

Conversation

gmpinder
Copy link
Member

No description provided.

@gmpinder gmpinder marked this pull request as draft January 26, 2024 05:05
@gmpinder gmpinder self-assigned this Jan 26, 2024
@gmpinder
Copy link
Member Author

I put too much other changes in this PR so I split out some of the changes to #17 and #18

@gmpinder gmpinder marked this pull request as ready for review February 14, 2024 19:16
@gmpinder
Copy link
Member Author

There are still some things I couldn't figure out, but the use of the stop signal works as intended. I'll need to go deeper into this later to see if there is a way to remove working containers from within buildah using the podman-api crate.

@gmpinder gmpinder enabled auto-merge (squash) February 14, 2024 19:41
@gmpinder gmpinder merged commit 9839878 into main Feb 14, 2024
1 check passed
@gmpinder gmpinder deleted the podman-api/cleanup branch February 14, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants