refactor: Create SigningDriver and CiDriver #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this going to pair well with bash |
This is mostly just for performing all the various cosign operations during build/init to make things easier if a user doesn't have cosign installed. It's more of a refactor than anything |
Creating a CI Driver that allows us to separate out logic for the various CI systems. This will allow easier extensibility when adding more implementations later.
gmpinder
changed the title
gmpinder
commented
Aug 11, 2024
gmpinder
force-pushed
the
signing-driver
branch
from
06509bd to
cdd8147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the driver for handling signing. It will make use of cosign if available and fall back to running the cosign container in docker or podman.