Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow empty custom modules dir #77

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

RoyalOughtness
Copy link
Contributor

No description provided.

@gmpinder
Copy link
Member

This won't work like you expect. Create an issue and I'll get a fix in for you tonight.

@gmpinder gmpinder closed this Feb 22, 2024
@RoyalOughtness
Copy link
Contributor Author

Doing so now. Out of curiosity, why won't this work?

@RoyalOughtness
Copy link
Contributor Author

#78

@xynydev
Copy link
Member

xynydev commented Feb 22, 2024

Out of curiosity, why won't this work?

The COPY command copies from outside the container to inside the container. The RUN command only works inside the container. So basically, this change would create a modules directory inside the container, then copy the modules directory from outside the container to inside the container.

@gmpinder gmpinder reopened this Feb 22, 2024
@gmpinder gmpinder enabled auto-merge (squash) February 22, 2024 20:49
@gmpinder gmpinder merged commit 681aab4 into blue-build:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants