refactor: Move templates to their own crate #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR logically separates out parts of the code to their own crates. As we've been adding more and more logic into the template for the Containerfile, compilation times have started to increase. This is mostly due to the fact that askama is a compilation time templating engine that uses macros to build rust code. I figured the best way to help with that was to seperate out the templating into its own crate. In order to do that while keeping the CLI as the root package, I had to also move ops, constants, and the recipe structs into their own sub-packages.
|
I'm not planning on merging this until we've gone through the release this weekend. I just decided on a whim to do some extra organizing. |
|
Further testing on my end showed not a significant decrease in compilation times. However, this refactor would still be good for future development when we move towards a Tauri app. |
bayou-brogrammer
previously approved these changes
Feb 25, 2024
bayou-brogrammer
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR logically separates out parts of the code to their own crates. As we've been adding more and more logic into the template for the Containerfile, compilation times have started to increase. This is mostly due to the fact that askama is a compilation time templating engine that uses macros to build rust code. I figured the best way to help with that was to seperate out the templating into its own crate. In order to do that while keeping the CLI as the root package, I had to also move ops, constants, and the recipe structs into their own sub-packages.