refactor!: make modules the main focus, move files into module folders #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superseded by just setup-nix
i couldn't find anything that uses this and i'm not sure it's even needed anymore and it's totally unmaintained
- i just noticed this is where the container tools for the container tools bling were coming from, but i already removed that... - ig this wasn't the only place to get container tools - the devpod bin wasn't used anywhere either and was locked to a specific version (that no-one maintained to update)
- tries to install nonexistant rpm
- also, there should only be one h1 per page
this is a nightmare to poke around in blindly, lets see where #104 goes
|
Looks very good. Maybe we can remove ublue-os backgrounds rpm related stuff here too? |
I was thinking that'd be a later PR but I can do it now too, sure. |
|
https://github.com/ublue-os/bling/blob/refactor/modules/bling/bling.sh#L12 This one needs to be: |
- also removes ublue-update rpm, this isn't used in the installer, the copr repo is
Good catch! This doesn't need to be at all actually, the |
superseded by use of MODULE_DIRECTORY
|
I would approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that removes features, features that were unmaintained and undocumented (or badly documented).