-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpm-ostree): Take into account the use of URL query parameters #351
fix(rpm-ostree): Take into account the use of URL query parameters #351
Conversation
@@ -8,23 +8,22 @@ get_yaml_array REPOS '.repos[]' "$1" | |||
if [[ ${#REPOS[@]} -gt 0 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shellcheck] reported by reviewdog 🐶
modules/modules/rpm-ostree/rpm-ostree.sh
Line 72 in 429319e
INSTALL_PKGS[$i]="${PKG//%OS_VERSION%/${OS_VERSION}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote this to prevent word splitting. SC2046
modules/modules/rpm-ostree/rpm-ostree.sh
Line 115 in 429319e
rpm-ostree override remove "${REMOVE_PKGS[@]}" $(printf -- "--install=%s " "${CLASSIC_PKGS[@]}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote this to prevent word splitting. SC2046
modules/modules/rpm-ostree/rpm-ostree.sh
Line 117 in 429319e
rpm-ostree override remove "${REMOVE_PKGS[@]}" $(printf -- "--install=%s " "${CLASSIC_PKGS[@]}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote this to prevent word splitting. SC2046
modules/modules/rpm-ostree/rpm-ostree.sh
Line 120 in 429319e
rpm-ostree override remove "${REMOVE_PKGS[@]}" $(printf -- "--install=%s " "${CLASSIC_PKGS[@]}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote this to prevent word splitting. SC2046
modules/modules/rpm-ostree/rpm-ostree.sh
Line 123 in 429319e
rpm-ostree override remove "${REMOVE_PKGS[@]}" $(printf -- "--install=%s " "${CLASSIC_PKGS[@]}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086
modules/modules/rpm-ostree/rpm-ostree.sh
Line 176 in 429319e
rpm-ostree override replace --experimental --from "repo=copr:copr.fedorainfracloud.org:${MAINTAINER}:${REPO_NAME}" ${REPLACE_STR} |
This should allow using query params for repo download URLs.