Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Lookup without DivideBy255 pre-processor #1157

Open
primenumber opened this issue Aug 14, 2020 · 0 comments · Fixed by #1161
Open

Lookup without DivideBy255 pre-processor #1157

primenumber opened this issue Aug 14, 2020 · 0 comments · Fixed by #1161
Assignees
Labels
enhancement New feature or request

Comments

@primenumber
Copy link
Contributor

Lookup operator assumes that input data is normalized to [0, 1].
But it is not efficient:
pre-processor divides input by 255.
func_Lookup multiplies input by 255.
It is totally waste...

blueoil convert should check meta.yaml whether it has DivideBy255 pre-processor, and func_Lookup should take additional parameter to determine multiply 255 or not.

@primenumber primenumber added the enhancement New feature or request label Aug 14, 2020
@primenumber primenumber self-assigned this Aug 14, 2020
oatawa1 pushed a commit to oatawa1/blueoil that referenced this issue Aug 28, 2020
## What this patch does to fix the issue.
Lookup operator supports inputs without normalized to 0〜1:
- `blueoil convert` command check network config whether DivideBy255 pre-processor exists or not
- `func_Lookup` takes new parameter `use_divide_by_255`
- `generate_project.py` has new option `-div` / `-no-div` to set `use_divide_by_255`
- set `use_divide_by_255` from whether DivideBy255 pre-processor exists or not

## Link to any relevant issues or pull requests.
Fix blue-oil#1157 .
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant