-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 2.7 support - add travis for python 3.7 #568
Conversation
@MaxBenChrist: I continued the work in #499 to remove python 2.7 support. I tried adding pandas 0.25 at the same time, but two tests fail, so it should be fixed in a subsequent PR. |
@MaxBenChrist: Any reason for holding back this PR? |
I'd also like to see this PR being merged so that we can move forward and support pandas=>0.25. @Froskekongen It's already a big PR, but it would be nice if it also included relaxing the constraint on pandas, at best by adding |
So, first of all thanks to @Froskekongen and @hugovk for this PR(s). I (also) think it is a good idea to drop 2.7 support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, most of them are minor. I can also implement some of them if you want.
Nice Nice Nice. |
Updated #499. Here, I also update python versions to 3.6 and 3.7.