Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 2.7 support - add travis for python 3.7 #568

Merged
merged 24 commits into from
Nov 20, 2019
Merged

Drop python 2.7 support - add travis for python 3.7 #568

merged 24 commits into from
Nov 20, 2019

Conversation

Froskekongen
Copy link
Contributor

@Froskekongen Froskekongen commented Aug 17, 2019

Updated #499. Here, I also update python versions to 3.6 and 3.7.

@Froskekongen
Copy link
Contributor Author

Froskekongen commented Aug 17, 2019

@MaxBenChrist: I continued the work in #499 to remove python 2.7 support. I tried adding pandas 0.25 at the same time, but two tests fail, so it should be fixed in a subsequent PR.

@Froskekongen Froskekongen changed the title P27 fix Drop python 2.7 support - add travis for python 3.7 Aug 19, 2019
@Froskekongen
Copy link
Contributor Author

@MaxBenChrist: Any reason for holding back this PR?

@tomzx
Copy link

tomzx commented Oct 15, 2019

I'd also like to see this PR being merged so that we can move forward and support pandas=>0.25.

@Froskekongen It's already a big PR, but it would be nice if it also included relaxing the constraint on pandas, at best by adding !=0.24.0, although I wouldn't mind not supporting old versions of pandas (<=0.25.0).

@nils-braun
Copy link
Collaborator

So, first of all thanks to @Froskekongen and @hugovk for this PR(s). I (also) think it is a good idea to drop 2.7 support.
I think we can and should separate the two parts - pandas and python version - if possible so it is easier to revert if needed.
I am adding some review comments, but most of them are minor things.

Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said, most of them are minor. I can also implement some of them if you want.

.travis.yml Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
tsfresh/feature_extraction/feature_calculators.py Outdated Show resolved Hide resolved
tsfresh/feature_extraction/extraction.py Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.449% when pulling 04363d2 on Froskekongen:p27_fix into 11e5c07 on blue-yonder:master.

@nils-braun
Copy link
Collaborator

Nice Nice Nice.
We finally get rid of it :-)

@nils-braun nils-braun merged commit b1dd1de into blue-yonder:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants