Fix docstring of c3 #590
Merged
Fix docstring of c3 #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues: * sum index should start from 1 and not 0 * x[i+2*lag] should not be squared Fix blue-yonder#585.
|
The referenced paper does not look very clear to me, please carefully review these changes. |
|
Sorry, I can also not answer as I am not an expert in the feature either. Clear thing for @MaxBenChrist ;-) |
|
We can merge this. You are correct, thank you. There are some other feature calculators where the index starts with i=0, you want to change them to i=1 as well in this pr? E.g. the sum in cid_ce should start with i=1 as well. @nils-braun the paper should be accessible to you as its from a physics department ;) |
|
I am not in a physics department anymore ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues:
Fix #585.