Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bindings #719

Merged
merged 5 commits into from
Jun 20, 2020
Merged

Fix bindings #719

merged 5 commits into from
Jun 20, 2020

Conversation

nils-braun
Copy link
Collaborator

I added a test for the dask bindings. Testing spark is hard, as we would need to install spark first.

This is definitely not impossible, but I think for now the dask test should be enough first.

@nils-braun
Fix bindings helper function
0954ae5 
After the pivoting was speed up in #705,
the helper function for the spark and dask bindings also needs to
change.

Additionally, this allows to introduce a fix for #709.
@nils-braun
Changelog
643f933
@nils-braun
Merge branch 'master' into bugfix/fix-bindings
ff4beb7
@nils-braun
Added test for dask bindings and some small fixes
c7371d9
@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 98.012% when pulling c7371d9 on bugfix/fix-bindings into 7656f51 on master.

@nils-braun nils-braun merged commit d353c0a into master Jun 20, 2020
@nils-braun nils-braun deleted the bugfix/fix-bindings branch June 20, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nils-braun @coveralls