Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure with newer pandas version #737

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

nils-braun
Copy link
Collaborator

That should remove a failure which comes up in newer pandas versions because the testing is more strict.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #737 into main will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   96.11%   96.28%   +0.16%     
==========================================
  Files          18       18              
  Lines        1622     1695      +73     
  Branches      322      322              
==========================================
+ Hits         1559     1632      +73     
  Misses         31       31              
  Partials       32       32              
Impacted Files Coverage Δ
tsfresh/utilities/distribution.py 93.39% <0.00%> (+0.06%) ⬆️
tsfresh/feature_extraction/feature_calculators.py 97.31% <0.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2cb23...a383c5a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 3, 2020

Result of Benchmark Tests

Benchmark Min Max Mean Mean on Repo HEAD
tests/benchmark.py::test_benchmark_small_data 9.84 9.98 9.93 +- 0.06 10.70 +- 0.22
tests/benchmark.py::test_benchmark_large_data 6.07 6.18 6.12 +- 0.06 5.31 +- 0.05
tests/benchmark.py::test_benchmark_with_selection 7.69 7.75 7.71 +- 0.03 7.27 +- 0.20

@nils-braun nils-braun merged commit 43838c9 into main Aug 3, 2020
@nils-braun nils-braun deleted the bugfix/compare-correct-frequencies branch August 3, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants